[webkit-reviews] review granted: [Bug 181057] com.apple.WebKit.WebContent.Development crashed in com.apple.WebCore: WebCore::UserMediaRequest::stop + 126 : [Attachment 329956] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 181057: com.apple.WebKit.WebContent.Development crashed in
com.apple.WebCore: WebCore::UserMediaRequest::stop + 126
https://bugs.webkit.org/show_bug.cgi?id=181057

Attachment 329956: Patch

https://bugs.webkit.org/attachment.cgi?id=329956&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 329956
  --> https://bugs.webkit.org/attachment.cgi?id=329956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329956&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:280
> +    Ref<UserMediaRequest> protectedThis(*this);

This is quite subtle, so I it think it would be a good idea to add a comment
about why it is necessary to protect this because of the side effects of
clearing m_pendingActivationMediaStream.