[webkit-reviews] review granted: [Bug 94458] Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests : [Attachment 329947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 20 13:08:23 PST 2017


Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 94458: Assertion failure in MessagePort::contextDestroyed in
http/tests/security/MessagePort/event-listener-context.html, usually attributed
to later tests
https://bugs.webkit.org/show_bug.cgi?id=94458

Attachment 329947: Patch

https://bugs.webkit.org/attachment.cgi?id=329947&action=review




--- Comment #43 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 329947
  --> https://bugs.webkit.org/attachment.cgi?id=329947
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329947&action=review

r=me

> Source/WebCore/dom/MessagePort.cpp:232
> +    return !hasPendingActivity() || (!m_started  || m_closed);

nit: Looks like there is an extra space in there.


More information about the webkit-reviews mailing list