[webkit-reviews] review granted: [Bug 163826] REGRESSION(r207238): [GTK] Layout test storage/domstorage/events/basic-body-attribute.html is failing : [Attachment 329913] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Ms2ger <Ms2ger at igalia.com>'s
request for review:
Bug 163826: REGRESSION(r207238): [GTK] Layout test
storage/domstorage/events/basic-body-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=163826

Attachment 329913: Patch

https://bugs.webkit.org/attachment.cgi?id=329913&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 329913
  --> https://bugs.webkit.org/attachment.cgi?id=329913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329913&action=review

We are currently skipping this test on Mac (bug #148435), Windows (bug
#160447), iOS (bug #155201) and WPE. All of these bugs have been open for a
year or more. For your consideration I suggest that we try to unskip the test
on all of these ports instead of just unskipping it on GTK.

> LayoutTests/storage/domstorage/events/basic-body-attribute.html:98
> +    shouldBeNull("storageEventList[7].key", "");

The second argument is not necessary.