[webkit-reviews] review granted: [Bug 180348] Split layout of RenderMathMLRow into smaller steps : [Attachment 329911] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Frédéric Wang (:fredw)
[back 03/01/2018] <fred.wang at free.fr>'s request for review:
Bug 180348: Split layout of RenderMathMLRow into smaller steps
https://bugs.webkit.org/show_bug.cgi?id=180348

Attachment 329911: Patch

https://bugs.webkit.org/attachment.cgi?id=329911&action=review




--- Comment #8 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 329911
  --> https://bugs.webkit.org/attachment.cgi?id=329911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329911&action=review

Thanks for the explanation.
r=me

> LayoutTests/mathml/mrow-preferred-width-with-out-of-flow-child.html:8
> +    <p>This test passes if the absolute positioned child is not taken in
account in the preferred width computation.</p>

Nit: Usually you have a description of the test (something like you have
wrote). And then the condition of how to visually check it passes, things like
"you'll see a green square and not red" (I believe this can be improved :-)).
Nit 2: Maybe we could do this test in WPT too (or only there, dunno how the
export process on WebKit is going).