[webkit-reviews] review denied: [Bug 181006] Element fullscreen interface should display the location : [Attachment 329843] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 19 16:42:59 PST 2017

Tim Horton <thorton at apple.com> has denied Jeremy Jones <jeremyj-wk at apple.com>'s
request for review:
Bug 181006: Element fullscreen interface should display the location

Attachment 329843: Patch


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 329843
  --> https://bugs.webkit.org/attachment.cgi?id=329843

View in context: https://bugs.webkit.org/attachment.cgi?id=329843&action=review

>>> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:1273
>>> +NSString *simplifiedUserVisibleString(NSURL *url)
>> I am somewhat surprised to see this code end up in WebKit! We should
probably have a discussion.
> Also, you should note that other parts of WebKit (Drag and Drop) use
LinkPresentation for this.

Actually, just r- for propagating this code to a third place.

More information about the webkit-reviews mailing list