[webkit-reviews] review granted: [Bug 180998] Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration : [Attachment 329822] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180998: Web Inspector: Network Table - Update the Time column to include
the total duration not just the download duration
https://bugs.webkit.org/show_bug.cgi?id=180998

Attachment 329822: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=329822&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 329822
  --> https://bugs.webkit.org/attachment.cgi?id=329822
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=329822&action=review

r=me, with a comment.

> Source/WebInspectorUI/UserInterface/Models/Resource.js:545
> +    get downloadDuration()

Are there plans to use `downloadDuration` in the very near future? If not let's
remove it. I think `totalDuration` makes sense as a name event with out, since
we have a `receiveDuration`.