[webkit-reviews] review granted: [Bug 180969] Don't convert pasted content to use blob URL in WebKit1 : [Attachment 329823] Restores the old behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 19 14:41:46 PST 2017

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 180969: Don't convert pasted content to use blob URL in WebKit1

Attachment 329823: Restores the old behavior


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 329823
  --> https://bugs.webkit.org/attachment.cgi?id=329823
Restores the old behavior

View in context: https://bugs.webkit.org/attachment.cgi?id=329823&action=review

> Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125
> +    destinationWebView.get().frameLoadDelegate = delegate.get();

Nit - we usually write using bracket notation (as [destinationWebView
setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for the
other places in this file)

More information about the webkit-reviews mailing list