[webkit-reviews] review granted: [Bug 180950] We should use "error" redirect mode for fetching service worker scripts : [Attachment 329694] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180950: We should use "error" redirect mode for fetching service worker
scripts
https://bugs.webkit.org/show_bug.cgi?id=180950

Attachment 329694: Patch

https://bugs.webkit.org/attachment.cgi?id=329694&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 329694
  --> https://bugs.webkit.org/attachment.cgi?id=329694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329694&action=review

>
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/regi
stration-security-error.https-expected.txt:6
> +FAIL Registering redirected script assert_throws: Registration of redirected
script should fail. function "function () { throw e }" threw object "TypeError:
Script URL
https://localhost:9443/service-workers/service-worker/resources/redirect.py?Red
irect=%2Fresources%2Fregistration-worker.js fetch resulted in error:
Redirections are not allowed" that is not a DOMException SecurityError:
property "code" is equal to undefined, expected 18

It does not seem there is any change of behavior, except for the message to be
more precise.
Maybe this test was throwing for a different reason?