[webkit-reviews] review granted: [Bug 180892] [Attachment Support] Support representing pasted or dropped content using attachment elements : [Attachment 329561] Depends on https://bugs.webkit.org/show_bug.cgi?id=180853

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 180892: [Attachment Support] Support representing pasted or dropped content
using attachment elements
https://bugs.webkit.org/show_bug.cgi?id=180892

Attachment 329561: Depends on https://bugs.webkit.org/show_bug.cgi?id=180853

https://bugs.webkit.org/attachment.cgi?id=329561&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 329561
  --> https://bugs.webkit.org/attachment.cgi?id=329561
Depends on https://bugs.webkit.org/show_bug.cgi?id=180853

View in context: https://bugs.webkit.org/attachment.cgi?id=329561&action=review

> Source/WebCore/ChangeLog:10
> +	   replaceRichContentWithAttachmentsIfNecessary to replace object
elements with attachments; see comments below for

Still slightly concerned about all <object>s becoming <attachment>s.

> Source/WebCore/ChangeLog:28
> +	   of generating markup from NSTextAttachments; this currently causes
the web process to crash on an unrecognized
> +	   selector.

Crazy