[webkit-reviews] review granted: [Bug 180853] [Attachment Support] Insert images as inline attachments when pasting and dropping : [Attachment 329514] Slight test tweaks

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 180853: [Attachment Support] Insert images as inline attachments when
pasting and dropping
https://bugs.webkit.org/show_bug.cgi?id=180853

Attachment 329514: Slight test tweaks

https://bugs.webkit.org/attachment.cgi?id=329514&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 329514
  --> https://bugs.webkit.org/attachment.cgi?id=329514
Slight test tweaks

View in context: https://bugs.webkit.org/attachment.cgi?id=329514&action=review

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:425
> +    HashMap<AtomicString, RefPtr<Blob>> urlToBlobMap;

Is it at all possible to factor this out? It seems like these same four lines
show up a bunch of times.

> Source/WebCore/html/HTMLAttachmentElement.cpp:127
> +	       setAttributeWithoutSynchronization(HTMLNames::titleAttr,
m_file->name());

I swear I've seen this code before