[webkit-reviews] review requested: [Bug 180770] Web Inspector: replace HTMLCanvasElement with CanvasRenderingContext for instrumentation logic : [Attachment 329619] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 17 12:46:27 PST 2017
Devin Rousso <webkit at devinrousso.com> has asked for review:
Bug 180770: Web Inspector: replace HTMLCanvasElement with
CanvasRenderingContext for instrumentation logic
https://bugs.webkit.org/show_bug.cgi?id=180770
Attachment 329619: Patch
https://bugs.webkit.org/attachment.cgi?id=329619&action=review
--- Comment #73 from Devin Rousso <webkit at devinrousso.com> ---
Created attachment 329619
--> https://bugs.webkit.org/attachment.cgi?id=329619&action=review
Patch
It looks like it's possible for willDeleteProgram and isShaderProgramDisabled
to be called on a ShaderProgram that has already been deleted via
deleteProgram, so we don't want to ASSERT for an InspectorShaderProgram.
More information about the webkit-reviews
mailing list