[webkit-reviews] review requested: [Bug 180770] Web Inspector: replace HTMLCanvasElement with CanvasRenderingContext for instrumentation logic : [Attachment 329588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 16 17:50:38 PST 2017


Devin Rousso <webkit at devinrousso.com> has asked  for review:
Bug 180770: Web Inspector: replace HTMLCanvasElement with
CanvasRenderingContext for instrumentation logic
https://bugs.webkit.org/show_bug.cgi?id=180770

Attachment 329588: Patch

https://bugs.webkit.org/attachment.cgi?id=329588&action=review




--- Comment #57 from Devin Rousso <webkit at devinrousso.com> ---
Created attachment 329588

  --> https://bugs.webkit.org/attachment.cgi?id=329588&action=review

Patch

Taking a different approach.  Instead of trying to add InspectorInstrumentation
hooks to ~CanvasRenderingContext, we can expand the usage of the CanvasObserver
concept and rely on the destruction of the CanvasBase to know when the
CanvasRenderingContext will be destroyed.


More information about the webkit-reviews mailing list