[webkit-reviews] review requested: [Bug 180770] Web Inspector: replace HTMLCanvasElement with CanvasRenderingContext for instrumentation logic : [Attachment 329562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 15 23:07:21 PST 2017


Devin Rousso <webkit at devinrousso.com> has asked  for review:
Bug 180770: Web Inspector: replace HTMLCanvasElement with
CanvasRenderingContext for instrumentation logic
https://bugs.webkit.org/show_bug.cgi?id=180770

Attachment 329562: Patch

https://bugs.webkit.org/attachment.cgi?id=329562&action=review




--- Comment #48 from Devin Rousso <webkit at devinrousso.com> ---
Created attachment 329562

  --> https://bugs.webkit.org/attachment.cgi?id=329562&action=review

Patch

I'm not 100% sure about this, but I think that the InstrumentingAgents are
wiped out whenever a Frame is removed.	The failing tests checked that canvas
contexts within iframes are destroyed after the iframe navigates or is removed.
 As a result, since the InstrumentingAgents don't exist anymore, we don't have
a way to remove the existing contexts from the CanvasAgent's list, meaning that
they are still listed there even though they don't exist anymore.  The solution
is to not delete the code inside InspectorCanvasAgent::frameNavigated that
finds all the tracked contexts for the navigating frame and removes them. 
Hopefully :|


More information about the webkit-reviews mailing list