[webkit-reviews] review granted: [Bug 180789] Support Autoscrolling in contenteditable for WK2 : [Attachment 329542] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 180789: Support Autoscrolling in contenteditable for WK2
https://bugs.webkit.org/show_bug.cgi?id=180789

Attachment 329542: Patch

https://bugs.webkit.org/attachment.cgi?id=329542&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329542
  --> https://bugs.webkit.org/attachment.cgi?id=329542
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329542&action=review

> Source/WebCore/page/EventHandler.h:339
> +    WEBCORE_EXPORT void startTextAutoscroll(RenderObject* renderer, const
FloatPoint& position);

position -> positionInWindow

> Source/WebCore/page/EventHandler.h:342
> +    bool m_isAutoscrolling { false };

My comment about not needing this and using the timer state still stands.

> Source/WebCore/page/ios/EventHandlerIOS.mm:563
> +void EventHandler::startTextAutoscroll(RenderObject* renderer, const
FloatPoint& position)

position -> positionInWindow

> Source/WebKit/UIProcess/WebPageProxy.h:573
> +    void startAutoscrollAtPosition(const WebCore::FloatPoint&);

Name the parameter positionInWindow

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:721
> +void WebPageProxy::startAutoscrollAtPosition(const WebCore::FloatPoint&
position)

Name the parameter positionInWindow

> Source/WebKit/WebProcess/WebPage/WebPage.messages.in:102
> +    StartAutoscrollAtPosition(WebCore::FloatPoint position)

Name the parameter positionInWindow

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1386
> +void WebPage::startAutoscrollAtPosition(const WebCore::FloatPoint& position)

Name the parameter positionInWindow