[webkit-reviews] review denied: [Bug 180879] webkitpy: Newline when MeteredStream is cleaned up : [Attachment 329512] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 15 14:32:33 PST 2017
Jonathan Bedard <jbedard at apple.com> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 180879: webkitpy: Newline when MeteredStream is cleaned up
https://bugs.webkit.org/show_bug.cgi?id=180879
Attachment 329512: Patch
https://bugs.webkit.org/attachment.cgi?id=329512&action=review
--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 329512
--> https://bugs.webkit.org/attachment.cgi?id=329512
Patch
This isn't quite correct.
What we're looking to do here is to output a newline if the metered stream was
the last one to print to stderr. This output results in an extra newline if
there is something else which has printed to stderr between the last metered
print and teardown.
More information about the webkit-reviews
mailing list