[webkit-reviews] review granted: [Bug 180870] API test WebKit.WebsiteDataStoreCustomPaths is failing : [Attachment 329502] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 15 11:38:21 PST 2017


Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 180870: API test WebKit.WebsiteDataStoreCustomPaths is failing
https://bugs.webkit.org/show_bug.cgi?id=180870

Attachment 329502: Patch

https://bugs.webkit.org/attachment.cgi?id=329502&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 329502
  --> https://bugs.webkit.org/attachment.cgi?id=329502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329502&action=review

r=me with suggestion.

> Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:66
> +   
send(Messages::WebProcess::EstablishWorkerContextConnectionToStorageProcess {
m_serviceWorkerPageID, store, idToUse }, 0);

initialSessionID.value_or(PAL::SessionID::defaultSessionID()) ?


More information about the webkit-reviews mailing list