[webkit-reviews] review granted: [Bug 180781] Playing media elements which call "pause(); play()" will have the play promise rejected. : [Attachment 329498] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 180781: Playing media elements which call "pause(); play()" will have the
play promise rejected.
https://bugs.webkit.org/show_bug.cgi?id=180781

Attachment 329498: Patch

https://bugs.webkit.org/attachment.cgi?id=329498&action=review




--- Comment #12 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 329498
  --> https://bugs.webkit.org/attachment.cgi?id=329498
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329498&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3501
> +	   if (m_readyState <= HAVE_CURRENT_DATA)
> +	       scheduleEvent(eventNames().waitingEvent);
> +	   else if (m_readyState >= HAVE_FUTURE_DATA)
> +	       scheduleNotifyAboutPlaying();

Nit: you should mention this fix in the ChangeLog.