[webkit-reviews] review denied: [Bug 178498] Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property : [Attachment 329164] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178498: Web Inspector: Styles Redesign: Typing semicolon at the end of
value should move to the next property
https://bugs.webkit.org/show_bug.cgi?id=178498

Attachment 329164: Patch

https://bugs.webkit.org/attachment.cgi?id=329164&action=review




--- Comment #10 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 329164
  --> https://bugs.webkit.org/attachment.cgi?id=329164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329164&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:513
> +	   let text = this._valueElement.textContent;
> +	   if (window.getSelection().getRangeAt(0).startOffset !== text.length)
> +	       return;

Typing ; should move to the next property even if it's before the suggestion
hint.

Consider:

  float: r[ight]

[irht] is a suggestion hint here. Typing ; should move the focus to the next
property.

SpreadsheetTextField.prototype._getPrefix returns text without the suggestion
hint. You can make it public and possibly rename to something more meaningful.