[webkit-reviews] review granted: [Bug 180682] Storage Access API: Implement frame-specific access in the document.cookie layer : [Attachment 329391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 14 13:25:17 PST 2017


Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 180682: Storage Access API: Implement frame-specific access in the
document.cookie layer
https://bugs.webkit.org/show_bug.cgi?id=180682

Attachment 329391: Patch

https://bugs.webkit.org/attachment.cgi?id=329391&action=review




--- Comment #27 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 329391
  --> https://bugs.webkit.org/attachment.cgi?id=329391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329391&action=review

> Source/WebCore/loader/EmptyFrameLoaderClient.h:36
> +    std::optional<uint64_t> frameID() const override { return 0; }
> +    std::optional<uint64_t> pageID() const override { return 0; }

These should probably return nullopt


More information about the webkit-reviews mailing list