[webkit-reviews] review granted: [Bug 180804] [DFG] Reduce register pressure of WeakMapGet to be used for 32bit : [Attachment 329343] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180804: [DFG] Reduce register pressure of WeakMapGet to be used for 32bit
https://bugs.webkit.org/show_bug.cgi?id=180804

Attachment 329343: Patch

https://bugs.webkit.org/attachment.cgi?id=329343&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 329343
  --> https://bugs.webkit.org/attachment.cgi?id=329343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329343&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10977
> +    std::optional<GPRTemporary> index;

Why optional? Does GPRTemporary have an empty constructor? If not, maybe it’s
worth adding and you can just WTFMove() to it below instead of emplace

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10982
> +	   index.emplace(this, Reuse, hash);

Does Reuse only reuse if we’re the last user of the value?