[webkit-reviews] review granted: [Bug 180689] Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace : [Attachment 329356] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 180689: Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB
colorspace
https://bugs.webkit.org/show_bug.cgi?id=180689

Attachment 329356: Patch

https://bugs.webkit.org/attachment.cgi?id=329356&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 329356
  --> https://bugs.webkit.org/attachment.cgi?id=329356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329356&action=review

> Source/WebCore/ChangeLog:12
> +	   Existing and new code mistakenly allocated colorspaces on every
call, because
> +	   they didn't initialize the static variable on the first call. Avoid
this mistake
> +	   by using dispatch_once() in these functions.

Seems like overkill to me, but I guess this does make them thread-safe whereas
before they could only be safely called on the main thread.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:102
> +	   linearRGBColorSpace sRGBColorSpaceRef();

Looks like this is missing an "="