[webkit-reviews] review granted: [Bug 180794] Add SPI to set the service worker registration directory to _WKWebsiteDataStoreConfiguration : [Attachment 329310] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180794: Add SPI to set the service worker registration directory to
_WKWebsiteDataStoreConfiguration
https://bugs.webkit.org/show_bug.cgi?id=180794

Attachment 329310: Patch

https://bugs.webkit.org/attachment.cgi?id=329310&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 329310
  --> https://bugs.webkit.org/attachment.cgi?id=329310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329310&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:42
>  @property (nonatomic, copy, setter=_setWebStorageDirectory:) NSURL
*_webStorageDirectory;
>  @property (nonatomic, copy, setter=_setIndexedDBDatabaseDirectory:) NSURL
*_indexedDBDatabaseDirectory;
> + at property (nonatomic, copy, setter=_setServiceWorkerRegistrationDirectory:)
NSURL *_serviceWorkerRegistrationDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA),
ios(WK_IOS_TBA));
>  @property (nonatomic, copy, setter=_setWebSQLDatabaseDirectory:) NSURL
*_webSQLDatabaseDirectory;
>  @property (nonatomic, copy, setter=_setCookieStorageFile:) NSURL
*_cookieStorageFile;
>  @property (nonatomic, copy, setter=_setResourceLoadStatisticsDirectory:)
NSURL *_resourceLoadStatisticsDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA),
ios(WK_IOS_TBA));

Seems kinda crazy that we require the client to set these separately for
correct behavior.