[webkit-reviews] review granted: [Bug 180479] Don't require perl(File::Copy::Recursive) : [Attachment 329305] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 180479: Don't require perl(File::Copy::Recursive)
https://bugs.webkit.org/show_bug.cgi?id=180479

Attachment 329305: Patch

https://bugs.webkit.org/attachment.cgi?id=329305&action=review




--- Comment #37 from Darin Adler <darin at apple.com> ---
Comment on attachment 329305
  --> https://bugs.webkit.org/attachment.cgi?id=329305
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329305&action=review

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:52
> +	   make_path($destination) if (!-d $destination);

This doesn’t seem to match the documentation of make_path. The documentation
says it works like "mkdir -p", which does not complain if a directory already
exists.

Perl coding style comments: The parentheses here are not needed. Might consider
"unless" instead of "if !".