[webkit-reviews] review granted: [Bug 180787] REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources : [Attachment 329296] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 13 20:27:36 PST 2017


Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 180787: REGRESSION: Web Inspector: Opening inspector crashes page if there
are empty resources
https://bugs.webkit.org/show_bug.cgi?id=180787

Attachment 329296: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=329296&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 329296
  --> https://bugs.webkit.org/attachment.cgi?id=329296
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=329296&action=review

r=me

> LayoutTests/inspector/page/empty-or-missing-resources.html:22
> +	   }

v. nice test :)

> Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:177
> +    if (content.isEmpty())

We really should have ASSERT_OR_RETURN(String(), content.isEmpty()) or
something like that. Unfortunately, our codebase completely mixes up #ifndef
NDEBUG and #if !LOG_DISABLED, so this would require some refactoring to not get
compiled out.


More information about the webkit-reviews mailing list