[webkit-reviews] review granted: [Bug 180682] Storage Access API: Implement frame-specific access in the document.cookie layer : [Attachment 329245] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 180682: Storage Access API: Implement frame-specific access in the
document.cookie layer
https://bugs.webkit.org/show_bug.cgi?id=180682

Attachment 329245: Patch

https://bugs.webkit.org/attachment.cgi?id=329245&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 329245
  --> https://bugs.webkit.org/attachment.cgi?id=329245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329245&action=review

Don't break the linux build.  Otherwise r=me

> Source/WebCore/platform/network/CacheValidation.cpp:351
> +	       return
cookieRequestHeaderFieldValue(NetworkStorageSession::defaultStorageSession(),
request.firstPartyForCookies(), request.url(), std::nullopt, std::nullopt,
includeSecureCookies).first;

We should look into passing in real values here.

> Source/WebKit/Shared/mac/CookieStorageShim.mm:64
> +    if
(!WebProcess::singleton().ensureNetworkProcessConnection().connection().sendSyn
c(Messages::NetworkConnectionToWebProcess::CookieRequestHeaderFieldValue(PAL::S
essionID::defaultSessionID(), firstPartyForCookiesURL, inRequestURL,
std::nullopt, std::nullopt, includeSecureCookies),
Messages::NetworkConnectionToWebProcess::CookieRequestHeaderFieldValue::Reply(c
ookies, secureCookiesAccessed), 0))

This is no big deal.  I filed https://bugs.webkit.org/show_bug.cgi?id=180766 to
get rid of this code on all platforms where we have ITP.