[webkit-reviews] review granted: [Bug 180743] [Web Animations] Implement the "updating the finished state" procedure : [Attachment 329239] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 180743: [Web Animations] Implement the "updating the finished state"
procedure
https://bugs.webkit.org/show_bug.cgi?id=180743

Attachment 329239: Patch

https://bugs.webkit.org/attachment.cgi?id=329239&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329239
  --> https://bugs.webkit.org/attachment.cgi?id=329239
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329239&action=review

> Source/WebCore/animation/WebAnimation.h:99
> +    enum class IgnoreHoldTime { Yes, No };

IgnoreHoldTime::No is a double negative. Might be better as RespectHoldTime {
Yes, No }.