[webkit-reviews] review granted: [Bug 180756] REGRESSION(225597): Can't select a text box or web view on a page when VO is on. : [Attachment 329231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 13 11:06:37 PST 2017


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 180756: REGRESSION(225597): Can't select a text box or web view on a page
when VO is on.
https://bugs.webkit.org/show_bug.cgi?id=180756

Attachment 329231: Patch

https://bugs.webkit.org/attachment.cgi?id=329231&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 329231
  --> https://bugs.webkit.org/attachment.cgi?id=329231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329231&action=review

Looks good. Please address the confusing comment. r=me assuming EWS is fine.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=180756

<rdar://problem/35996158>

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:593
> +#endif

I wonder if we really need to exclude this. Surely we want to avoid calling
into _AXUIElementNotify... if NSApp is not running?

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:80
> +    // Leak a boost onto the WebContent process if the NSApplication run
loop is not used.

I don't know what Leak a boost" means?


More information about the webkit-reviews mailing list