[webkit-reviews] review granted: [Bug 180729] Update the SVG use element's shadow trees explicitly before the style recalc : [Attachment 329196] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 13 00:38:41 PST 2017
Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 180729: Update the SVG use element's shadow trees explicitly before the
style recalc
https://bugs.webkit.org/show_bug.cgi?id=180729
Attachment 329196: Patch
https://bugs.webkit.org/attachment.cgi?id=329196&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 329196
--> https://bugs.webkit.org/attachment.cgi?id=329196
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=329196&action=review
Nice. I think you could also remove this from
Style::TreeResolver::resolveComposedTree:
// FIXME: SVG <use> element may cause tree mutations during style recalc.
it.dropAssertions();
> Source/WebCore/svg/SVGUseElement.cpp:197
> void SVGUseElement::willRecalcStyle(Style::Change change)
> {
> - // FIXME: Shadow tree should be updated before style recalc.
> - if (m_shadowTreeNeedsUpdate)
> - updateShadowTree();
> SVGGraphicsElement::willRecalcStyle(change);
> }
This function can be removed completely.
More information about the webkit-reviews
mailing list