[webkit-reviews] review granted: [Bug 180679] Storage Access API: Implement frame-specific access in the network storage session layer : [Attachment 329076] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 180679: Storage Access API: Implement frame-specific access in the network
storage session layer
https://bugs.webkit.org/show_bug.cgi?id=180679

Attachment 329076: Patch

https://bugs.webkit.org/attachment.cgi?id=329076&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 329076
  --> https://bugs.webkit.org/attachment.cgi?id=329076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329076&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:288
> +    WTFLogAlways("ResourceLoadLog |
NetworkStorageSession::isStorageAccessGranted(), resourceDomain: %s,
firstPartyDomain: %s, frameID: %llu, pageID: %llu.",
resourceDomain.utf8().data(), firstPartyDomain.utf8().data(), frameID, pageID);

Let's not add a WTFLogAlways here.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:302
> +    WTFLogAlways("ResourceLoadLog |
NetworkStorageSession::setStorageAccessGranted(), resourceDomain: %s,
firstPartyDomain: %s, frameID: %llu, pageID: %llu.",
resourceDomain.utf8().data(), firstPartyDomain.utf8().data(), frameID, pageID);

Also remove this log.

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:413
> +    // Dummy

Remove.

>
LayoutTests/http/tests/storageAccess/request-and-grant-storage-access-cross-ori
gin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and
-try-access-from-right-frame-expected.txt:19
> +Client-side document.cookie: partitionedCookie=value

Once CookieJarMac is updated, this result will change.