[webkit-reviews] review granted: [Bug 180724] Fill out some Poisoned APIs, fix some bugs, and add some tests. : [Attachment 329169] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 180724: Fill out some Poisoned APIs, fix some bugs, and add some tests.
https://bugs.webkit.org/show_bug.cgi?id=180724

Attachment 329169: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=329169&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 329169
  --> https://bugs.webkit.org/attachment.cgi?id=329169
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=329169&action=review

r=me

> Source/WTF/wtf/Poisoned.h:55
> +struct isValidReference : std::integral_constant<bool,
!isFunctionPointer<T>::value && !isVoidPointer<T>::value> { };

What's a "valid reference"? What makes it "valid"?

> Source/WTF/wtf/Poisoned.h:194
> +constexpr uintptr_t makePoison(uint32_t key)

inline?