[webkit-reviews] review granted: [Bug 180552] [WK2] Expose image via WKBundleHitTestResult API : [Attachment 329133] Patch v3

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zach Li
<zacharyli323 at gmail.com>'s request for review:
Bug 180552: [WK2] Expose image via WKBundleHitTestResult API
https://bugs.webkit.org/show_bug.cgi?id=180552

Attachment 329133: Patch v3

https://bugs.webkit.org/attachment.cgi?id=329133&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329133
  --> https://bugs.webkit.org/attachment.cgi?id=329133
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=329133&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:185
> +    BitmapImage& bitmapImage = downcast<BitmapImage>(*image);
> +    IntSize size(bitmapImage.size());
> +    auto webImage = WebImage::create(size, static_cast<ImageOptions>(0));
> +
> +    auto graphicsContext = webImage->bitmap().createGraphicsContext();
> +    graphicsContext->drawImage(bitmapImage, {{ }, size});

This needs a FIXME comment saying something like "FIXME: need to handle EXIF
rotation".