[webkit-reviews] review denied: [Bug 180430] [EME] Add layout test for InitData and InitDataType in CENC encrypted event : [Attachment 329000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 12 02:24:28 PST 2017

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180430: [EME] Add layout test for InitData and InitDataType in CENC
encrypted event

Attachment 329000: Patch


--- Comment #14 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 329000
  --> https://bugs.webkit.org/attachment.cgi?id=329000

(In reply to Jer Noble from comment #12)
> Okay, the unfortunate part is that the Mac port will never be able to
> support EME through the standard flat-file, non-HLS, non-MSE path. So please
> just make a global platform/mac/TestExpectations entry (rather than an El
> Capitan one) for this test.

Ok, there is no problem in running it though MSE if it's better for you too, I
think we can go with the second option of patch with some small changes:
* place the file under media-source instead of encrypted-media and call it
* Rename the objects to MediaSourceLoaderSimple and SourceBufferLoaderSimple.
* In the tests changelog remove the JS functions cause they are not interesting
and be a bit more verbose about the files you create. It would be nice to know
what medias-enc.js, the media itself and the simple loader includes.

More information about the webkit-reviews mailing list