[webkit-reviews] review granted: [Bug 180524] HTML-page with <object type="image/svg+xml" data="foo.svg"> often is blank : [Attachment 329036] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 23:19:31 PST 2017

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 180524: HTML-page with <object type="image/svg+xml" data="foo.svg"> often
is blank

Attachment 329036: Patch


--- Comment #23 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 329036
  --> https://bugs.webkit.org/attachment.cgi?id=329036

View in context: https://bugs.webkit.org/attachment.cgi?id=329036&action=review

> Source/WebCore/page/DOMWindow.cpp:1264
> +    // Force enough layout in the parent document to ensure that the
FrameView has been resized.
> +    if (auto* frameElement = this->frameElement())
> +	   frameElement->clientHeight();

Since you don't care about the result, you should just call 


directly instead of relying on it being called as a side effect (and maybe
adding a helper for it to Element?).

> Source/WebCore/page/DOMWindow.cpp:1280
> +    if (auto* frameElement = this->frameElement())
> +	   frameElement->clientWidth();

Same here with WidthDimensionsCheck

More information about the webkit-reviews mailing list