[webkit-reviews] review granted: [Bug 180471] Implement {DOMMimeTypeArray, DOMPluginArray}::supportedPropertyNames(). : [Attachment 328565] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 21:36:49 PST 2017


Darin Adler <darin at apple.com> has granted Ms2ger <Ms2ger at igalia.com>'s request
for review:
Bug 180471: Implement {DOMMimeTypeArray,
DOMPluginArray}::supportedPropertyNames().
https://bugs.webkit.org/show_bug.cgi?id=180471

Attachment 328565: Patch

https://bugs.webkit.org/attachment.cgi?id=328565&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 328565
  --> https://bugs.webkit.org/attachment.cgi?id=328565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328565&action=review

> Source/WebCore/plugins/DOMMimeTypeArray.cpp:97
> +    unsigned size = mimes.size();
> +
> +    Vector<AtomicString> result;
> +    result.reserveInitialCapacity(size);
> +
> +    for (unsigned i = 0; i < size; ++i)
> +	   result.uncheckedAppend(AtomicString(mimes[i].type));

Writing it like this gets rid of an unnecessary local variable, uses a modern
for loop, gets rid of unnecessary explicit conversion to AtomicString, and
saves a little bit of reference count churn by using WTFMove.

    Vector<AtomicString> result;
    result.reserveInitialCapacity(mimes.size());
    for (auto& info : mimes)
	result.uncheckedAppend(WTFMove(info.type));

> Source/WebCore/plugins/DOMPluginArray.cpp:85
> +    const Vector<PluginInfo>& plugins = data->publiclyVisiblePlugins();
> +    unsigned size = plugins.size();
> +
> +    Vector<AtomicString> result;
> +    result.reserveInitialCapacity(size);
> +
> +    for (unsigned i = 0; i < size; ++i)
> +	   result.uncheckedAppend(AtomicString(plugins[i].name));

Writing it like this gets rid of an unnecessary written-out type, an
unnecessary local variable, uses a modern for loop, and gets rid of unnecessary
explicit conversion to AtomicString.

    auto& plugins = data->publiclyVisiblePlugins();

    Vector<AtomicString> result;
    result.reserveInitialCapacity(plugins.size());
    for (auto& plugin : plugins)
	result.uncheckedAppend(plugin.name);


More information about the webkit-reviews mailing list