[webkit-reviews] review denied: [Bug 180676] Web Inspector: Styles Redesign: tabbing on commented out property throws exception : [Attachment 329068] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 180676: Web Inspector: Styles Redesign: tabbing on commented out property
throws exception
https://bugs.webkit.org/show_bug.cgi?id=180676

Attachment 329068: Patch

https://bugs.webkit.org/attachment.cgi?id=329068&action=review




--- Comment #3 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 329068
  --> https://bugs.webkit.org/attachment.cgi?id=329068
Patch

This doesn't address every case:

[Error] TypeError: null is not an object (evaluating
'lastProperty.valueTextField.startEditing')
	startEditingLastProperty (SpreadsheetCSSStyleDeclarationEditor.js:116)
	cssStyleDeclarationSectionStartEditingPreviousRule
(SpreadsheetRulesStyleDetailsPanel.js:226)
	spreadsheetSelectorFieldDidChange
(SpreadsheetCSSStyleDeclarationSection.js:172:83)
	_handleKeyDown (SpreadsheetSelectorField.js:113)
	_handleKeyDown