[webkit-reviews] review granted: [Bug 180660] [WinCairo] Enable running sharded tests : [Attachment 329006] patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 180660: [WinCairo] Enable running sharded tests
https://bugs.webkit.org/show_bug.cgi?id=180660

Attachment 329006: patch

https://bugs.webkit.org/attachment.cgi?id=329006&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 329006
  --> https://bugs.webkit.org/attachment.cgi?id=329006
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329006&action=review

> Tools/Scripts/webkitpy/port/win.py:440
> +    # FIXME I don't see why base Port depends on UNIX separator, but I'm
afraid breaking other environment
> +    TEST_PATH_SEPARATOR = os.sep

I don't think this is a good comment.  If this is necessary, then it's
necessary.