[webkit-reviews] review denied: [Bug 168447] AX: when invert colors is on, double-invert certain media elements in UserAgentStyleSheet : [Attachment 329008] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 13:24:31 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 168447: AX: when invert colors is on, double-invert certain media elements
in UserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=168447

Attachment 329008: patch

https://bugs.webkit.org/attachment.cgi?id=329008&action=review




--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329008
  --> https://bugs.webkit.org/attachment.cgi?id=329008
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329008&action=review

> Source/WebCore/Modules/modern-media-controls/controls/media-controls.css:133
> +    :host { filter: invert(100%); } /* WebKit native audio and video, with
controls. */

You can't assume that shadow DOM is only used for audio and media controls. We
may use it for other purposes that don't involve media.


More information about the webkit-reviews mailing list