[webkit-reviews] review denied: [Bug 180644] [JSC] Optimize Object.assign by single transition acceleration and reify shortcut : [Attachment 328962] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180644: [JSC] Optimize Object.assign by single transition acceleration and
reify shortcut
https://bugs.webkit.org/show_bug.cgi?id=180644

Attachment 328962: Patch

https://bugs.webkit.org/attachment.cgi?id=328962&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 328962
  --> https://bugs.webkit.org/attachment.cgi?id=328962
Patch

I’m r- because I don’t want to add more code for this reification method table.
I’ve already spoken to JF and other folks offline about removing this call from
this code path. I think the right answer is to either:
- Call defineOwnProperty for static getter/setters on classes. We can probably
keep calling putDirect when defining it on an object literal since plain
objects don’t have lazy properties. 
- move this reification call into define_getter_setter_by_id