[webkit-reviews] review granted: [Bug 180646] StyleBench improvements : [Attachment 328969] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 180646: StyleBench improvements
https://bugs.webkit.org/show_bug.cgi?id=180646

Attachment 328969: patch

https://bugs.webkit.org/attachment.cgi?id=328969&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 328969
  --> https://bugs.webkit.org/attachment.cgi?id=328969
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review

r=me

> PerformanceTests/ChangeLog:8
> +	   - Remove :empty rule from global stylesheet. It caused all tests to
hit positional pseudo-class code paths.

Do we need a dedicated subtest to cover this pathology, since it showed a
performance difference between Safari and Firefox?