[webkit-reviews] review granted: [Bug 180657] [Web Animations] Enqueue and dispatch animation events : [Attachment 328998] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 10:36:17 PST 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 180657: [Web Animations] Enqueue and dispatch animation events
https://bugs.webkit.org/show_bug.cgi?id=180657

Attachment 328998: Patch

https://bugs.webkit.org/attachment.cgi?id=328998&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 328998
  --> https://bugs.webkit.org/attachment.cgi?id=328998
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328998&action=review

> Source/WebCore/animation/WebAnimation.cpp:232
> +    if (m_timeline && m_timeline->isDocumentTimeline())
> +	  
downcast<DocumentTimeline>(*m_timeline).enqueueAnimationPlaybackEvent(WTFMove(e
vent));
> +    // Otherwise, queue a task to dispatch event at animation. The task
source for this task is the DOM manipulation task source.
> +    else {

This indentation is weird. Put the comment inside the { }


More information about the webkit-reviews mailing list