[webkit-reviews] review denied: [Bug 180642] [WinCairo] DLLLauncherMain should use SetDllDirectory : [Attachment 328960] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 180642: [WinCairo] DLLLauncherMain should use SetDllDirectory
https://bugs.webkit.org/show_bug.cgi?id=180642

Attachment 328960: Patch

https://bugs.webkit.org/attachment.cgi?id=328960&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 328960
  --> https://bugs.webkit.org/attachment.cgi?id=328960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328960&action=review

> Tools/ChangeLog:12
> +	   * win/DLLLauncher/DLLLauncherMain.cpp:

We should keep this the same as Source/JavaScriptCore/shell/DLLLauncherMain.cpp

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:128
>      wstring pathGStreamer =
copyEnvironmentVariable(L"GSTREAMER_1_0_ROOT_X86") + L"bin";

We should probably remove this.  Nobody uses gstreamer with wincairo any more.

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:132
>      wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES") +
L"\\bin32";
>  #endif
> -    prependPath(pathWinCairo);
> +    if (!SetDllDirectory(pathWinCairo.c_str()))
> +	   fatalError(programName, L"Failed to SetDllDirectory");

What does this do if there is no WEBKIT_LIBRARIES environment variable?