[webkit-reviews] review denied: [Bug 180470] [Readable Streams API] Throw RangeError if a size is provided when creating a readable byte stream : [Attachment 328564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 04:54:17 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Romain Bellessort
<romain.wkt at gmail.com>'s request for review:
Bug 180470: [Readable Streams API] Throw RangeError if a size is provided when
creating a readable byte stream
https://bugs.webkit.org/show_bug.cgi?id=180470

Attachment 328564: Patch

https://bugs.webkit.org/attachment.cgi?id=328564&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 328564
  --> https://bugs.webkit.org/attachment.cgi?id=328564
Patch

Code is ok, test is redudant as it commit
da06ef1c8668bd121a461405361fc7f4615b6cd6 of WPT shows at
https://github.com/w3c/web-platform-tests.git. So you want to import that test
instead of creating a new one.


More information about the webkit-reviews mailing list