[webkit-reviews] review denied: [Bug 180524] HTML-page with <object type="image/svg+xml" data="foo.svg"> often is blank : [Attachment 328928] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 10 11:22:29 PST 2017


Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 180524: HTML-page with <object type="image/svg+xml" data="foo.svg"> often
is blank
https://bugs.webkit.org/show_bug.cgi?id=180524

Attachment 328928: Patch

https://bugs.webkit.org/attachment.cgi?id=328928&action=review




--- Comment #17 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 328928
  --> https://bugs.webkit.org/attachment.cgi?id=328928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328928&action=review

> Source/WebCore/page/DOMWindow.cpp:1278
> +    if (!m_frame->isMainFrame())
> +	   m_frame->document()->updateLayoutIgnorePendingStylesheets();

Frame size doesn't depend on layout of its content (except with frame
flattening). There must a better way to fix this than forcing a layout.


More information about the webkit-reviews mailing list