[webkit-reviews] review denied: [Bug 180529] Web Inspector: Optionally log WebKit log parameters as JSON : [Attachment 328697] Proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 8 14:56:22 PST 2017
Brian Burg <bburg at apple.com> has denied Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 180529: Web Inspector: Optionally log WebKit log parameters as JSON
https://bugs.webkit.org/show_bug.cgi?id=180529
Attachment 328697: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=328697&action=review
--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 328697
--> https://bugs.webkit.org/attachment.cgi?id=328697
Proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=328697&action=review
r- and deferring detailed review until this compiles.
> Source/WebCore/platform/graphics/iso/ISOVTTCue.h:56
> + String toJSON() const;
The style throughout Web Inspector code is to either call this method
toJSONValue() if returning JSON::Value, and otherwise toJSONString(). I
recommend choosing either of those.
More information about the webkit-reviews
mailing list