[webkit-reviews] review granted: [Bug 180603] Implement transferToImageBitmap for WebGL offscreen canvas objects : [Attachment 328866] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 8 14:00:21 PST 2017


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 180603: Implement transferToImageBitmap for WebGL offscreen canvas objects
https://bugs.webkit.org/show_bug.cgi?id=180603

Attachment 328866: Patch

https://bugs.webkit.org/attachment.cgi?id=328866&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 328866
  --> https://bugs.webkit.org/attachment.cgi?id=328866
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328866&action=review

> Source/WebCore/html/ImageBitmap.cpp:57
> +RefPtr<ImageBitmap> ImageBitmap::create(IntSize size)

Any reason not to return a Ref<ImageBitmap> here?

> Source/WebCore/html/ImageBitmap.cpp:59
> +    RefPtr<ImageBitmap> imageBitmap = adoptRef(new ImageBitmap);

You can use auto here.


More information about the webkit-reviews mailing list