[webkit-reviews] review denied: [Bug 180558] Clearing all Website Data should remove service worker registrations on disk : [Attachment 328848] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180558: Clearing all Website Data should remove service worker
registrations on disk
https://bugs.webkit.org/show_bug.cgi?id=180558

Attachment 328848: Patch

https://bugs.webkit.org/attachment.cgi?id=328848&action=review




--- Comment #24 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 328848
  --> https://bugs.webkit.org/attachment.cgi?id=328848
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328848&action=review

> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:268
> +    SQLiteStatement deleteStatement(*m_database, "DELETE FROM Records where
topOrigin=?");

topOrigin isn't right, is it?

a.com embedded in b.com, a request comes in to delete records for a.com - b.com
is the top origin, but we want to clear a.com records.

We need  "DELETE FROM Records WHERE origin=?"
Arguably we could *also* do topOrigin.

(Also please not "WHERE" is caps)

> Source/WebCore/workers/service/server/SWServer.cpp:-163
> -    // FIXME: We should clear entries in m_registrations, m_jobQueues and
m_workersByID.

This FIXME was removed but do we do this?