[webkit-reviews] review granted: [Bug 180287] REGRESSION(r221931): Row stretch doesn't work for grid container with min-height : [Attachment 328647] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 180287: REGRESSION(r221931): Row stretch doesn't work for grid container
with min-height
https://bugs.webkit.org/show_bug.cgi?id=180287

Attachment 328647: Patch

https://bugs.webkit.org/attachment.cgi?id=328647&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 328647
  --> https://bugs.webkit.org/attachment.cgi?id=328647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328647&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:944
> +    ASSERT(m_algorithm.freeSpace(direction()));
> +    return m_algorithm.freeSpace(direction()).value();

This assertion isn’t needed. Our version of std::optional::value includes an
assertion.