[webkit-reviews] review granted: [Bug 180572] Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy : [Attachment 328790] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180572: Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=180572

Attachment 328790: Patch

https://bugs.webkit.org/attachment.cgi?id=328790&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 328790
  --> https://bugs.webkit.org/attachment.cgi?id=328790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328790&action=review

r=me

> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:52
> +	   ASSERT_WITH_MESSAGE(!const_cast<Lock&>(m_lock).tryLock(),
"CAView::Handle's mutex must be held when calling this function");

Consider changing "mutex" to "lock".

> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:58
> +	   ASSERT_WITH_MESSAGE(!m_lock.tryLock(), "CAView::Handle's mutex must
be held when calling this function");

Consider changing "mutex" to "lock".