[webkit-reviews] review granted: [Bug 180561] Move Logger from PAL to WTF so it can be used outside of WebCore : [Attachment 328768] Updated patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 7 19:02:55 PST 2017
Alex Christensen <achristensen at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 180561: Move Logger from PAL to WTF so it can be used outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=180561
Attachment 328768: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=328768&action=review
--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 328768
--> https://bugs.webkit.org/attachment.cgi?id=328768
Updated patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=328768&action=review
r=me with comments
> Source/WTF/wtf/Logger.h:224
> +} // namespace PAL
This should be namespace WTF
> Source/WebCore/html/track/TrackBase.cpp:38
> +using namespace WTF;
Many WTF header files end with using WTF::Something;
Let's do that instead of this.
Then we can also replace the WTF::Logger with Logger
More information about the webkit-reviews
mailing list