[webkit-reviews] review granted: [Bug 180542] [EME] support update() for FairPlayStreaming in Modern EME API : [Attachment 328730] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 180542: [EME] support update() for FairPlayStreaming in Modern EME API
https://bugs.webkit.org/show_bug.cgi?id=180542

Attachment 328730: Patch

https://bugs.webkit.org/attachment.cgi?id=328730&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 328730
  --> https://bugs.webkit.org/attachment.cgi?id=328730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328730&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:968
> +    for (auto& sourceBuffer : m_mediaSourcePrivate->sourceBuffers())
> +	   sourceBuffer->setCDMInstance(&instance);
> +
> +    m_cdmInstance = &instance;

Nit: would it be safer to set m_cdmInstance first in case the source buffer
callbacks have side effects?